New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choose better weather forecasting horizons #131
Conversation
…data; add forecast resolutions for 5T & 10T resolutions
[ | ||
job | ||
for job in app.queues["forecasting"].jobs | ||
if job.kwargs["timed_value_type"] != "Price" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you checking for != "Price"
instead of == "Weather"
? Also in line 224.
jobs = [ | ||
job | ||
for job in app.queues["forecasting"].jobs | ||
if job.kwargs["timed_value_type"] != "Price" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just flagging one more occurrence. Candidate util function?
sorted(jobs, key=lambda x: x.kwargs["horizon"]), forecast_horizons | ||
): | ||
assert job.kwargs["horizon"] == horizon | ||
assert job.kwargs["start"] == parse_date(post_message["start"]) + horizon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment would be useful for this one, not self evident.
If weather data is posted which is itself not forecasts, we should choose better forecasts for forecasting.
Also: add choices for horizons if the data resolution is smaller than 15 minutes.