Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODE, SDE, and Discrete Problem dispatches for ParsedReactionNetwork #105

Open
TorkelE opened this issue Oct 5, 2023 · 2 comments
Open

Comments

@TorkelE
Copy link
Member

TorkelE commented Oct 5, 2023

Since these contain initial conditions and parameter values, would it make sense to create dispatches to e.g. do

using ReactionNetworkImporters
BCR = loadrxnetwork(BNGNetwork(), "BCR.net")
tspan = (0.0,1000.0)
oprob = ODEProblem(BCR, tspan)
@isaacsas
Copy link
Member

isaacsas commented Oct 5, 2023

The generated ReactionSystem has u0 and p added as defaults via metadata. See the README. You shouldn’t need to pass them in.

@TorkelE
Copy link
Member Author

TorkelE commented Oct 5, 2023

You mean using

oprob = ODEProblem(rn, Float64[], (0.0, tf), Float64[])

I thought this was slightly different, as I do not give the actual ParsedReactionNetwork, and utilise the default values in its contained ReactionSystem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants