Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect Float64 assumptions in diff_to_zero #825

Open
isaacsas opened this issue May 13, 2024 · 0 comments
Open

incorrect Float64 assumptions in diff_to_zero #825

isaacsas opened this issue May 13, 2024 · 0 comments

Comments

@isaacsas
Copy link
Member

diff_2_zero(expr) = (Symbolics.is_derivative(expr) ? 0.0 : expr)

seems problematic. We shouldn't be assuming a type. This whole code path should probably just delete the derivative terms instead of setting them to zero to avoid making assumptions about types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant