Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of remove_conserved when creating an ODESystem - and make it default to true? #773

Open
ranocha opened this issue Jan 26, 2024 · 4 comments

Comments

@ranocha
Copy link
Member

ranocha commented Jan 26, 2024

We have just discussed this on Slack. See https://docs.sciml.ai/Catalyst/stable/faqs/#How-to-index-solution-objects-using-symbolic-variables-and-observables?

@ranocha ranocha changed the title Improve documentation of remove_conserved when creating an ODESystem Improve documentation of remove_conserved when creating an ODESystem - and make it default to true? Jan 26, 2024
@isaacsas
Copy link
Member

@isaacsas
Copy link
Member

@TorkelE what do you think about defaulting it to true? I know we've discussed but I can't remember if you had a reason not to do it by default for ODEs?

@ChrisRackauckas
Copy link
Member

I don't see a reason to not make it true. Enforcing conservation generally makes the numerics more stable, and structural simplify should then eliminate the equations anyways so we'd get smaller simpler equations to solve.

@isaacsas
Copy link
Member

OK, we can go with it always being true for ODE models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants