Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making change set actions more verbose #821

Open
m1keil opened this issue Sep 6, 2019 · 1 comment
Open

Consider making change set actions more verbose #821

m1keil opened this issue Sep 6, 2019 · 1 comment

Comments

@m1keil
Copy link
Contributor

m1keil commented Sep 6, 2019

I just noticed that the delete option is shared between both the general stack destruction and change set deletion. While it makes CLI footprint smaller, it does introduce a subtle risk.

For example, right now to delete a change set, you need to do something like:

sceptre delete --yes PATH MYCHANGESETNAME

However it's relatively trivial to just fat finger and type

sceptre delete --yes PATH

instead. It is also becomes almost trivial to mess that up with bash scripting.

I suggest to add an explicit flag to the create/delete command so that changeset operations cannot be mixed up with regular stack operations:

sceptre delete [OPTIONS] PATH [--Change CHANGE_SET_NAME]

So if user explicitly type something like

sceptre delete --yes PATH --Change

it will error instead of destroying the entire stack.

@ngfgrant
Copy link
Contributor

ngfgrant commented Feb 3, 2020

Hey @m1keil

I can see where you are coming from here. I think we keep it the same for v2 as it would be a breaking change. but something to consider for v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants