You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just noticed that the delete option is shared between both the general stack destruction and change set deletion. While it makes CLI footprint smaller, it does introduce a subtle risk.
For example, right now to delete a change set, you need to do something like:
sceptre delete --yes PATH MYCHANGESETNAME
However it's relatively trivial to just fat finger and type
sceptre delete --yes PATH
instead. It is also becomes almost trivial to mess that up with bash scripting.
I suggest to add an explicit flag to the create/delete command so that changeset operations cannot be mixed up with regular stack operations:
I just noticed that the
delete
option is shared between both the general stack destruction and change set deletion. While it makes CLI footprint smaller, it does introduce a subtle risk.For example, right now to delete a change set, you need to do something like:
However it's relatively trivial to just fat finger and type
instead. It is also becomes almost trivial to mess that up with bash scripting.
I suggest to add an explicit flag to the create/delete command so that changeset operations cannot be mixed up with regular stack operations:
So if user explicitly type something like
it will error instead of destroying the entire stack.
The text was updated successfully, but these errors were encountered: