Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with change sets for multiple stacks fails unless all cause updates #723

Open
henrist opened this issue Jun 6, 2019 · 8 comments · May be fixed by #1192
Open

Update with change sets for multiple stacks fails unless all cause updates #723

henrist opened this issue Jun 6, 2019 · 8 comments · May be fixed by #1192
Labels
type: bug

Comments

@henrist
Copy link

henrist commented Jun 6, 2019

update -c xxx fails if there are multiple stacks resolved, and not all have updates (i.e. generates valid change sets). This is due to not all change sets statuses being READY, so it bails with exit(1).

Party covered in #520, but this is a bug, not a broader improvement.

I've done some initial hacking on this issue and will try to push a PR soon.
@henrist henrist changed the title Updates with change sets for multiple stacks fails unless all cause updates Update with change sets for multiple stacks fails unless all cause updates Jun 6, 2019
@ngfgrant
Copy link
Contributor

ngfgrant commented Jun 21, 2019 •
edited

I think 987e220 should fix this which is now in the 2.1.4 if you have time @henrist could you checkout and test?

@henrist
Copy link
Author

henrist commented Jun 21, 2019 •
edited

This is why it fails:

https://github.com/cloudreach/sceptre/blob/9df6a65f435f83bc8c99be266581d613bd7c6994/sceptre/cli/update.py#L60-L63

The code requires all items in the plan to have updates

@RobReus
Copy link

RobReus commented Jun 30, 2020

As far as I know, this is still an issue in 2.3.0. Any idea when it will be fixed?

@henrist any chance of creating that pull request with the hacking you did on this issue? Might be able to help on solving this issue so it can be merged into upstream.

@ngfgrant
Copy link
Contributor

This now might work when 20b824a was merged to master (not formally released yet)

@henrist
Copy link
Author

henrist commented Jul 1, 2020

I'll devote some time during the weekend to check (both the changes mentioned and if needed push som partial changes in a PR).

henrist added a commit to henrist/sceptre that referenced this issue Jul 7, 2020
@henrist
Fix update coommand with change sets for multiple stacks
db3b58b 
Previously the update command would exit if any change sets status
was not equal to READY. However, when a stack does not contain
any updates, it will not be READY since there is nothing to execute.
This should not prevent other change sets to be executed.

Fixes Sceptre#723
henrist added a commit to henrist/sceptre that referenced this issue Jul 7, 2020
@henrist
Fix update coommand with change sets for multiple stacks
58188bb 
Previously the update command would exit if any change sets status
was not equal to READY. However, when a stack does not contain
any updates, it will not be READY since there is nothing to execute.
This should not prevent other change sets to be executed.

[Resolves Sceptre#723]
henrist added a commit to henrist/sceptre that referenced this issue Jul 8, 2020
@henrist
Fix update coommand with change sets for multiple stacks
1c108d4 
Previously the update command would exit if any change sets status
was not equal to READY. However, when a stack does not contain
any updates, it will not be READY since there is nothing to execute.
This should not prevent other change sets to be executed.

[Resolves Sceptre#723]
henrist added a commit to henrist/sceptre that referenced this issue Jul 8, 2020
@henrist
Fix update command with change sets for multiple stacks
20061cb 
Previously the update command would exit if any change sets status
was not equal to READY. However, when a stack does not contain
any updates, it will not be READY since there is nothing to execute.
This should not prevent other change sets to be executed.

[Resolves Sceptre#723]
@henrist henrist mentioned this issue Jul 8, 2020
Closed
9 tasks
@henrist
Copy link
Author

henrist commented Jul 8, 2020

The PR is out - see #917

@ngfgrant
Copy link
Contributor

ngfgrant commented Jul 8, 2020

Thanks I’ll have a look soon I take it master doesn’t work?

@henrist
Copy link
Author

henrist commented Jul 8, 2020 •
edited

Thanks I’ll have a look soon I take it master doesn’t work?

Yep, correct. The code i refered to in #723 (comment) still caused the bailout.

harkylton pushed a commit to harkylton/sceptre that referenced this issue Jan 13, 2022
@henrist @harkylton
Fix update command with change sets for multiple stacks
5e1efe5 
Previously the update command would exit if any change sets status
was not equal to READY. However, when a stack does not contain
any updates, it will not be READY since there is nothing to execute.
This should not prevent other change sets to be executed.

[Resolves Sceptre#723]
harkylton pushed a commit to harkylton/sceptre that referenced this issue Jan 13, 2022
@henrist @harkylton
[Resolves Sceptre#723] Fix update command with change sets for multip…
c3fd38f 
…le stacks

Previously the update command would exit if any change sets status
was not equal to READY. However, when a stack does not contain
any updates, it will not be READY since there is nothing to execute.
This should not prevent other change sets to be executed.

To get around this, we introduce another change set status, NO_CHANGES,
and handle that gracefully.

To clean up the output a bit, we also pass on describing the changes
for empty change sets.
@harkylton harkylton linked a pull request Jan 13, 2022 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
3 participants
@henrist @ngfgrant @RobReus