-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NDK crash in ARScene on version 2.0.4 #435
Comments
Hi @Antiglobalist |
You can reproduce it by this code
So it requires two changes: |
I wouldn't call session.pause() or session.resume() I believe the lifecycle takes care of those for us. |
You can try to apply the changes that i wrote upper |
Sorry @Antiglobalist I skimmed over the part where you said you removed those custom calls. Can you confirm this issue is new in 2.0.4, and was not present in 2.0.3? If you can pinpoint what version this begins to occur, it can help us determine a fix - if destroy is being called twice, then wouldn't this cause an issue regardless of the use of |
Sure To confirm it, I added a flag so that there is no double call ` private val testAppScope = MainScope()
|
Hi all, thanks for the work here! Just a heads up that I still see NDK crashes coming from ARCore when calling destroy which seem to indicate a double call. I'm trying to investigate on my end but just wanted to mention it. I see the issue when building the latest from main branch (corresponding to release 2.1.0). |
I forgot to share the stacktrace I'm seeing:
|
@sameerjj / @Antiglobalist I just submitted a PR change which appears to fix the issue on my end if you'd like to review, thanks! Thanks all and @ThomasGorisse for the great library! |
@kmayoral Hi there! |
Reopen if it's still the case in v2.2.0 |
I have described it in PR(Unfortunately it is late :) )
#408 (comment)
The text was updated successfully, but these errors were encountered: