-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StatType mana = 0 #389
Comments
I was wrong |
but still, there is something wrong here, mana sometimes is considered as "2" like in In |
So, i'm primarrily going off of enum ItemModType. This is very siminilar to g_statToJson but not quite identical. i suppose it is correct to change aowow/includes/types/item.class.php Lines 754 to 770 in 70a93d9
to $jsonType = $type;
// base stat
switch ($type)
{
case ITEM_MOD_MANA:
$jsonType = 2; // g_statToJson expects mana on idx 2
case ITEM_MOD_HEALTH:
case ITEM_MOD_AGILITY:
case ITEM_MOD_STRENGTH:
case ITEM_MOD_INTELLECT:
case ITEM_MOD_SPIRIT:
case ITEM_MOD_STAMINA:
$x .= '<span><!--stat'.$jsonType .'-->'.($qty > 0 ? '+' : '-').abs($qty).' '.Lang::item('statType', $type).'</span><br />';
break;
default: // rating with % for reqLevel
$green[] = $this->parseRating($type, $qty, $interactive, $causesScaling);
} are there even heirlooms that grant a flat increase of mana/health..? |
I made a quick check and I did not find items with stat type 0, about health you can find some items |
https://wowgaming.altervista.org/aowow/?item=6673&xml in any case, there is a discrepancy between tooltip and json stats |
oh god it's worse.... Lines 777 to 790 in de2fa37
|
there is something weird indeed |
Describe the bug and how to reproduce itinitem.class.php
we are considering asstatType 0 value
theMANA
but it's wrong, 0 should be a null/blank value and mana should be2
(1 is Health, which is correct but Mana should not be 0 but 2).Inincludes/types/item.class.php
line 746 there is a funny comment// i think i fucked up somewhere mapping item_mods: offsets may be required somewhere
I think that this comment refers probably to this error.Same error is present inlocale_enus.php
line 1803 where statType 0 is mana and statType 2 is null.In AzerothCore I can't find in item_template an item with stat_type* = 2, so I can't double-check with wowhead or other sources (it seems unused), but it should not be 0 I guess.The text was updated successfully, but these errors were encountered: