Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroic raid boss not accessible #236

Open
BarbzYHOOL opened this issue Oct 14, 2020 · 10 comments
Open

Heroic raid boss not accessible #236

BarbzYHOOL opened this issue Oct 14, 2020 · 10 comments
Labels
Support i am unsure about something

Comments

@BarbzYHOOL
Copy link

Search for "sartharion", you will only find this guy:
https://db.rising-gods.de/?npc=28860

And there is no heroic loot associated with it.

Here is the heroic version (I think):
https://db.rising-gods.de/?npc=31311

Btw we can see the heroic version shares many loots with the normal version and on wowhead it's not the case, dunno if it's an issue in the cores (TC/AC) or if it's an issue with aowow

@BarbzYHOOL
Copy link
Author

Ok, I meant "hard mode boss" and not heroic.

So npc 31311 is for the 25 man raid version? if so, just close this issue :D

@Faq
Copy link

Faq commented Oct 17, 2020

in db:
image

from tc wiki:

For Dungeons: 
difficulty_entry_1 = 5 (Heroic)

For Raids:
difficulty_entry_1 = 25 (Normal)
difficulty_entry_2 = 10 (Heroic)
difficulty_entry_3 = 25 (Heroic)

So 2 questions:

  1. should there be some reference or in search result show up also Sartharion difficulty_entry_1 when we search for name Sartharion ?
  2. What is that REFERENCE: 34166 thing showing up under loot on this link ?

@wodim
Copy link
Contributor

wodim commented Oct 21, 2020

References are loot groups, it means there's a 100% chance you'll get an item from the group 34166 which has its own items with different %s. The interface to show this is currently pretty poor it seems

@BarbzYHOOL
Copy link
Author

  1. i think it's just the 25 man version so it's accessible but it's confusing as we can't see its real ID
  2. cool tho i can't click the referenced_loot, doesn't open anything for me but i'm on old browser

@Sarjuuk Sarjuuk added the Support i am unsure about something label Oct 25, 2020
@Sarjuuk
Copy link
Owner

Sarjuuk commented Oct 25, 2020

1. should there be some reference or in search result show up also Sartharion difficulty_entry_1 when we search for name Sartharion?

Search results? No. That gets cluttered really fast with up to 5 times the results
As displayed on the page of the base entity? Maybe in the side bar.

2. What is that **REFERENCE: 34166** thing showing up under loot on this link?

ref-loot is normally merged into the loot as, yes, its fkin confusing to look at unfiltered. As the tcubuntu instance is catered to developers, it is displayed separately, so you can understand how the loot is actually composed.
No idea how to better display it.

1. i think it's just the 25 man version so it's accessible but it's confusing as we can't see its real ID  

the 'real' id is the base id. iirc the core uses the base entity and just applies the stats, flags and loot from the placeholder creatures onto it.

2. cool tho i can't click the referenced_loot, doesn't open anything for me but i'm on old browser

it doesn't do anything right now. It's just to display the chances of that reference being merged into the final loot.
maybe clicking it could apply a filter to this listview.

@wodim
Copy link
Contributor

wodim commented Oct 25, 2020

No idea how to better display it.

I've thought of something like this (just the design, the data is wrong):

image

@Sarjuuk
Copy link
Owner

Sarjuuk commented Oct 25, 2020

indentations are probably impossible with listviews.

@Faq
Copy link

Faq commented Oct 26, 2020

What about adding column with reference ID, next to item name so can also filter out if needed?

@Sarjuuk
Copy link
Owner

Sarjuuk commented Oct 26, 2020

Like the column next to % (drop chance)?

@Faq
Copy link

Faq commented Oct 27, 2020

Yeah, would look better 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support i am unsure about something
Projects
None yet
Development

No branches or pull requests

4 participants