Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution to SpriterMC #2

Open
wastedabuser opened this issue Dec 9, 2014 · 6 comments
Open

Contribution to SpriterMC #2

wastedabuser opened this issue Dec 9, 2014 · 6 comments

Comments

@wastedabuser
Copy link

I am using ASC 2.0.
I've fixed those and I would like to contribute to this project with other improvements of mine!

So far i have fixed the following issues:

  • Changing image texture does not seem to work (prevFileDirty and nextFileDirty);
  • Setting texture with different size results in stretching the texture to the original image size;
  • Playing the animation in reverse starts the sequence with the textures from the first key frame rather than the last.
  • Pivot points are parsed from the keys, but it seems they may appear on the file nodes.

Please, contact me! :)

@wastedabuser wastedabuser changed the title A lot of warning when compiling SpriterMC A lot of warnings when compiling SpriterMC Dec 9, 2014
@wastedabuser wastedabuser changed the title A lot of warnings when compiling SpriterMC Contribution to SpriterMC Dec 10, 2014
@Adolio
Copy link
Contributor

Adolio commented Jan 18, 2015

Hi @wastedabuser!
Nice! I'm really interrested by your fixes :) Could you share them through a fork ?
Thanks in advance

@wastedabuser
Copy link
Author

Yes, i just pushed my changes to a fork under my account. Unfortunately the line endings conversion messed things a bit :(

@Adolio
Copy link
Contributor

Adolio commented Jan 19, 2015

Thanks! No problem, I will try to identicate your changes by reconverting the files.

@Adolio
Copy link
Contributor

Adolio commented Jan 20, 2015

It works :) Thank you @wastedabuser !
Do you matter if I split your changes into several commits and create a pull request ?

@wastedabuser
Copy link
Author

Well, no problem.... but I wonder why do you need that?
If you found some issues i would like to pull them from you, of course :)

Adolio added a commit to Adolio/SpriterMC that referenced this issue Jan 24, 2015
Adolio added a commit to Adolio/SpriterMC that referenced this issue Jan 24, 2015
Adolio added a commit to Adolio/SpriterMC that referenced this issue Jan 24, 2015
Adolio added a commit to Adolio/SpriterMC that referenced this issue Jan 24, 2015
Author: wastedabuser
Refs SammyJoeOsborne#2
Adolio added a commit to Adolio/SpriterMC that referenced this issue Jan 24, 2015
Adolio added a commit to Adolio/SpriterMC that referenced this issue Jan 24, 2015
Adolio added a commit to Adolio/SpriterMC that referenced this issue Jan 24, 2015
Removed useless _isPlaying check & simplified call of updateVisuals()

Author: wastedabuser
Refs SammyJoeOsborne#2
@wastedabuser
Copy link
Author

@aureliendc, sorry for my later reply, i checked your commits and it seems it's not going to be a straight forward merge :( There are a lot of conflicts...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants