Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument remaining ingest cron scripts with performance logging #649

Open
auspicacious opened this issue Apr 1, 2020 · 3 comments
Open
Labels
Help Wanted A good place to get started. These issues should require minimal knowledge of safecast's domain.

Comments

@auspicacious
Copy link
Contributor

Also, adjust the logger script to always quote jq selectors, even when that selector is just .

See ingest/cron/logger.bash and logger_test.bash for examples.

@auspicacious auspicacious reopened this Apr 1, 2020
@auspicacious auspicacious added this to Soon in API Team board May 4, 2020
@auspicacious auspicacious added the Help Wanted A good place to get started. These issues should require minimal knowledge of safecast's domain. label May 4, 2020
@sasharevzin
Copy link
Collaborator

@auspicacious, is ingest/cron/logger.bash file part of the repo?

@matschaffer
Copy link
Contributor

It’s in the ingest repo https://github.com/Safecast/ingest/blob/master/cron/logger.bash

@matschaffer
Copy link
Contributor

Also worth noting that elastic apm is enabled for the api workers now which provides a bit of timing info. But since the jobs aren’t Ruby we don’t see the query timing I don’t think.

@matschaffer matschaffer moved this from Soon to Backburner in API Team board Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted A good place to get started. These issues should require minimal knowledge of safecast's domain.
Projects
API Team board
Backburner
Development

No branches or pull requests

3 participants