cannot accept share through 'Shared with you' view

[michielbdejong]

Clicking 'accept' or 'reject' in https://oc2.docker/index.php/apps/files/?dir=/&view=sharingin shows an error message and doesn't work.
The API call does return a 200 status code but with the following body:

{"ocs":{"meta":{
  "status":"failure",
  "statuscode":404,
  "message":"wrong share ID, share doesn't exist.",
  "totalitems":"",
  "itemsperpage":""
},"data":[]}}

[michielbdejong]

This only happens when trying to accept/decline from the 'Shared with you' view.
A workaround is to refresh the page and then accept through the modal dialog.

[michielbdejong]

It's probably coming from https://github.com/pondersource/core/blob/3a99facff69b2b14d6d0d294331e60dae2a002c0/apps/files_sharing/lib/Controller/RemoteOcsController.php#L117

[michielbdejong]

Turns out that getShares has the switch to the second ExternalManager, but acceptShare does not :(

[yasharpm]

Neither does declineShare. We need another PR into OwnCloud :(

[michielbdejong]

Yes! but a small one this time, and it should be easy to write.

[yasharpm]

Gonna do it tomorrow...

[yasharpm]

I have pushed the fix to the fixing_issue_240 branch of our fork of OwnCloud core.

[yasharpm]

This is not tested. I am working on a way to test it!

[michielbdejong]

Great! I updated dev-stock to use that branch of owncloud/core for opencloudmesh-testing and for rd-sram-testing. Building the images now.

[yasharpm]

Testing the fix...
There is bug is reproduced as follows:
Decline a share in the "shared with you". then share it again. This time try to accept using the notification pop up. It won't work.

[yasharpm]

It might be a bug that exists independently. Might be because we need different table constraints

[michielbdejong]

then share it again.

In my experience, when Marie declines a share, for Einstein it still looks like shared with Test Group, so he can't share it again?

I tried with Einstein removing Test Group from the sharees list and readding it after Marie had declined it, and then there is no problem, she can accept it in both ways.

[yasharpm]

I created an issue about it here on the OCM app repository.

[michielbdejong]

The original issue of this ticket is fixed in owncloud/core#40967