Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelCode computation is not consistent among classes. #91

Open
3 of 10 tasks
alexatstariongroup opened this issue Jan 23, 2020 · 0 comments
Open
3 of 10 tasks

ModelCode computation is not consistent among classes. #91

alexatstariongroup opened this issue Jan 23, 2020 · 0 comments

Comments

@alexatstariongroup
Copy link
Member

alexatstariongroup commented Jan 23, 2020

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of the CDP4-SDK
  • I have searched open and closed issues to ensure it has not already been reported

Description

Could already be fixed in IME issue #1014. Please check!!!

#197 co's implementinc the IModelCode interface all have own implementation of ModelCode() method. See:

https://github.com/RHEAGROUP/CDP4-SDK-Community-Edition/blob/development/CDP4Common/Poco/Parameter.cs#L56

and

https://github.com/RHEAGROUP/CDP4-SDK-Community-Edition/blob/development/CDP4Common/Poco/ParameterOverride.cs#L100

This is causing discrepancy -> Parameter model code already looks different from it's override.

Tasks:

  1. Describe what the model code should look like. Shall all model codes go to the top element? What if there is no Top Element?
  2. Make consistent in all cases.
  3. Take care to verify in browsers and the Excel Addin workbooks because model codes are very relevant.

Steps to Reproduce

Select a deeply nested parameter and copy its model code. Verify that the path does not go to the top element. Create an override on this parameter. Verify that modelcode of the override does go all the way to the top element.

System Configuration

  • CDP4 version:
    • CDP4Common:
    • CDP4JsonSerializer:
    • CDP4Dal:
    • CDP4JsonFileDal:
    • CDP4ServicesDal:
    • CDP4WspDal:
    • Other:
  • Environment (Operating system, version and so on):
  • .NET Framework version:
  • Additional information:
@alexatstariongroup alexatstariongroup added this to Backlog in COMET-CE Jan 23, 2020
@samatstariongroup samatstariongroup moved this from Backlog to Estimate 8-9-2022 in COMET-CE Sep 8, 2022
@lxatstariongroup lxatstariongroup moved this from Estimate 29-9-2022 to Backlog in COMET-CE Oct 27, 2022
@lxatstariongroup lxatstariongroup moved this from Backlog to Estimate 29-9-2022 in COMET-CE Oct 27, 2022
@lxatstariongroup lxatstariongroup moved this from Estimate 27-10-2022 to Backlog in COMET-CE Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
COMET-CE
  
Backlog
Development

No branches or pull requests

3 participants