Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CDP4Dal.Operations.ThingTransaction initialization and update some documentation #45

Open
3 of 10 tasks
IevhenIkonnykov opened this issue Apr 10, 2019 · 1 comment
Labels
enhancement quality Issue related to improvement of quality SDK
Projects

Comments

@IevhenIkonnykov
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of the CDP4-SDK
  • I have searched open and closed issues to ensure it has not already been reported

Description

In the second constructor move this.TransactionContext = parentTransaction.TransactionContext to the if statement where parentTransaction is checked for null.
Fix word "ass" to "add" in docs for AddCloneToContainer and UpdateContainer methods.

Steps to Reproduce

See the source code.

System Configuration

Does not matter.

  • CDP4 version:
    • CDP4Common:
    • CDP4JsonSerializer:
    • CDP4Dal:
    • CDP4JsonFileDal:
    • CDP4ServicesDal:
    • CDP4WspDal:
    • Other:
  • Environment (Operating system, version and so on):
  • .NET Framework version:
  • Additional information:
@IevhenIkonnykov
Copy link
Contributor Author

Merge method contains the following piece of code:

// check if the key in a sub-transaction correspond to a value in the current one
var existingKeyValue = this.updatedThing.SingleOrDefault(x => x.Value == keyValuePair.Key);
if (existingKeyValue.Key != null)
{
       this.updatedThing[existingKeyValue.Key] = keyValuePair.Value;
 }

which looks incorrect, because we might get NullPointer if existingKeyValue is null. There should be
if (existingKeyValue != null)

@alexatstariongroup alexatstariongroup added this to To do in Sprint 0 Oct 18, 2019
@alexatstariongroup alexatstariongroup added this to To Do in COMET-CE Oct 22, 2019
@alexatstariongroup alexatstariongroup moved this from Sprint Backlog to Backlog in COMET-CE Oct 22, 2019
@alexatstariongroup alexatstariongroup removed this from To do in Sprint 0 Oct 30, 2019
@samatstariongroup samatstariongroup added quality Issue related to improvement of quality enhancement SDK labels Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement quality Issue related to improvement of quality SDK
Projects
COMET-CE
  
Backlog
Development

No branches or pull requests

2 participants