Fix #262: Moved from Newtonsoft.Json to System.Text.Json #324
Conversation
antoineatstariongroup
requested review from
lxatstariongroup and
samatstariongroup
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I think that the issue found by SQ should be discarded and non-relevant with the context of the code |
| public override void Write(Utf8JsonWriter writer, PostOperation value, JsonSerializerOptions options) | ||
| { | ||
| writer.WriteStartObject(); | ||
| writer.WriteStartArray("_delete"); |
| { | ||
| domainOfExpertise.Name = jObject["name"].ToObject<string>(); | ||
| if(nameProperty.ValueKind == JsonValueKind.Null) |
There was a problem hiding this comment.
lets log at Trace level
| <PackageTags>CDP COMET ECSS-E-TM-10-25 JSON</PackageTags> | ||
| <PackageLicenseExpression>LGPL-3.0-only</PackageLicenseExpression> | ||
| <PackageReleaseNotes> | ||
| [BUMP] To CDP4Common 26.6.0 | ||
| </PackageReleaseNotes> | ||
| <PackageReadmeFile>README.md</PackageReadmeFile> |
There was a problem hiding this comment.
please restore the README.md
| @@ -0,0 +1,20 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
make sure to add some docs somewhere what the purpose is and how to use it
| emailAddress.ModifiedOn = jObject["modifiedOn"].ToObject<DateTime>(); | ||
| if(modifiedOnProperty.ValueKind == JsonValueKind.Null) | ||
| { | ||
| Logger.Trace("The non-nullabale modifiedOn property of the emailAddress {id} is null", emailAddress.Iid); |
Check warning
Code scanning / CodeQL
Exposure of private information Medium
| emailAddress.ThingPreference = jObject["thingPreference"].ToObject<string>(); | ||
| if(thingPreferenceProperty.ValueKind == JsonValueKind.Null) | ||
| { | ||
| Logger.Trace("The non-nullabale thingPreference property of the emailAddress {id} is null", emailAddress.Iid); |
Check warning
Code scanning / CodeQL
Exposure of private information Medium
| emailAddress.Value = jObject["value"].ToObject<string>(); | ||
| if(valueProperty.ValueKind == JsonValueKind.Null) | ||
| { | ||
| Logger.Trace("The non-nullabale value property of the emailAddress {id} is null", emailAddress.Iid); |
Check warning
Code scanning / CodeQL
Exposure of private information Medium
| emailAddress.VcardType = jObject["vcardType"].ToObject<VcardEmailAddressKind>(); | ||
| if(vcardTypeProperty.ValueKind == JsonValueKind.Null) | ||
| { | ||
| Logger.Trace("The non-nullabale vcardType property of the emailAddress {id} is null", emailAddress.Iid); |
Check warning
Code scanning / CodeQL
Exposure of private information Medium
| /// Initializes a new <see cref="PostOperationJsonConverter" /> instance. | ||
| /// </summary> | ||
| /// <param name="ignoreCopyProperty">Asserts that the <see cref="PostOperation.Copy"/> have to be ignored</param> | ||
| public PostOperationJsonConverter(bool ignoreCopyProperty = false) |
There was a problem hiding this comment.
the default should be true, since this is special for COMET and not supported by version 1,0.0 of 10-25
|
Prerequisites
Description
Fix #262
BREAKING CHANGES :