Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ValueSetConverter.ToValueSetString #240

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Improve ValueSetConverter.ToValueSetString #240

wants to merge 3 commits into from

Conversation

lxatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Improve ValueSetConverter.ToValueSetString

@lxatstariongroup lxatstariongroup self-assigned this Jul 5, 2022
@lxatstariongroup lxatstariongroup linked an issue Jul 6, 2022 that may be closed by this pull request
[IMPROVE] ValueSetConverter.ToValueSetString() #239
Open
3 tasks
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

samatstariongroup
samatstariongroup approved these changes Jul 7, 2022
View reviewed changes
CDP4Common.Tests/Helpers/ValueSetConverterTestFixture.cs
@@ -1,25 +1,24 @@
// --------------------------------------------------------------------------------------------------------------------
// <copyright file="ValueSetConverterTestFixture.cs" company="RHEA System S.A.">
// Copyright (c) 2015-2020 RHEA System S.A.
// <copyright file="ActionItem.cs" company="RHEA System S.A.">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect class name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samatstariongroup samatstariongroup samatstariongroup approved these changes

@nathanatstariongroup nathanatstariongroup nathanatstariongroup approved these changes

@antoineatstariongroup antoineatstariongroup antoineatstariongroup approved these changes

Assignees

@lxatstariongroup lxatstariongroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[IMPROVE] ValueSetConverter.ToValueSetString()
4 participants
@lxatstariongroup @samatstariongroup @nathanatstariongroup @antoineatstariongroup