Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finetuning ValueSetConverter.ToValueSetString #229

Open
3 tasks done
lxatstariongroup opened this issue Mar 2, 2022 · 0 comments
Open
3 tasks done

Finetuning ValueSetConverter.ToValueSetString #229

lxatstariongroup opened this issue Mar 2, 2022 · 0 comments

Comments

@lxatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of the COMET-SDK
  • I have searched open and closed issues to ensure it has not already been reported

Description

At the moment numeric (Double) values cannot be entered with group seperators, for example 123,123.10.
This is caused by the fact that the Double.TryParse call that is used in ValueSetConverter.ToValueSetString, uses NumberStyles.Float.
It should probably use NumberStyles.Any, so all possible numeric values can be converted to a ValueSet string.

Please notice that for example a Boolean Parametertype value entered by the user as a value of "0", or "1" leads to a positive Boolean.TryParse result, but also as a Double.TryParse result.
Order of individual code lines is important to stay backwards compatible and also collaboration with the ValueSetConverter.ToValueSetObject should be an area of interest, as boolean values are converted to real Boolean values there.
Seems like a boolean parametertype Value that is used in ValueSetConverter.ToValueSetString already doesn't work at the moment.
There might be other types that have similar problems.

@samatstariongroup samatstariongroup added this to Estimate 01-03-22 in COMET-CE Mar 7, 2022
@lxatstariongroup lxatstariongroup moved this from Estimate 14-04-22 to Backlog in COMET-CE Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
COMET-CE
  
Backlog
Development

No branches or pull requests

1 participant