Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Megamenu - hydration errors are causing lighthouse scores to tank #2386

Closed
2 tasks done
wicksipedia opened this issue Mar 27, 2024 · 1 comment · Fixed by SSWConsulting/SSW.MegaMenu#86, #2400 or #2403 · May be fixed by #2387
Closed
2 tasks done

⚠️ Megamenu - hydration errors are causing lighthouse scores to tank #2386

wicksipedia opened this issue Mar 27, 2024 · 1 comment · Fixed by SSWConsulting/SSW.MegaMenu#86, #2400 or #2403 · May be fixed by #2387
Assignees

Comments

@wicksipedia
Copy link
Member

wicksipedia commented Mar 27, 2024

When I was investigating #2385 and tried to run a lighthouse check locally for /consulting/sharepoint - hydration errors cause the score to tank

Image

Image

Tasks

@Harry-Ross
Copy link
Contributor

Image
Figure: Hydration errors still present on ssw.com.au

As there is still hydration errors occurring on production, I ran a diff checker on the server-rendered HTML of the production environment and PR environment and found there was only 1 difference:

Image
Figure: Source of ssw.com.au on the left (US timezone), source of a PR deployment (AU timezone)

This should be fixed by moving timezone logic to client-side rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment