Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Ensure important errors are being logged #670

Closed
3 tasks done
Tracked by #678
AttackOnMorty opened this issue Apr 15, 2024 · 2 comments · Fixed by #702
Closed
3 tasks done
Tracked by #678

✨ Ensure important errors are being logged #670

AttackOnMorty opened this issue Apr 15, 2024 · 2 comments · Fixed by #702
Assignees
Labels
Type: Feature A suggested idea for this project

Comments

@AttackOnMorty
Copy link
Member

AttackOnMorty commented Apr 15, 2024

Cc: @jimmidier @divgul @matt-goldman @piers-sinclair @adamcogan

Hi Team,

Pain

We do have some SophieBot errors logged into App Insights. But we need to double-check if we include all the important errors.

Tasks

Acceptance Criteria

Thanks!

@AttackOnMorty AttackOnMorty self-assigned this Apr 15, 2024
@AttackOnMorty AttackOnMorty added the Type: Feature A suggested idea for this project label Apr 22, 2024
@AttackOnMorty AttackOnMorty changed the title Ensure important errors are being logged ✨ Ensure important errors are being logged Apr 23, 2024
@AttackOnMorty
Copy link
Member Author

As per my conversation with @jimmidier, here are the important errors specific to SophieBot:

  • Query failure (Log question)
  • Error calling PeopleAPI (Log endpoint) (It's a common error and has been logged in App Insights)

@AttackOnMorty
Copy link
Member Author

✅ Done - The user's question will be stored in App Insights | exception | customDimensions | question field when the query failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature A suggested idea for this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant