Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix UniFi related queries #664

Closed
3 tasks done
AttackOnMorty opened this issue Jan 17, 2024 · 1 comment
Closed
3 tasks done

🐛 Fix UniFi related queries #664

AttackOnMorty opened this issue Jan 17, 2024 · 1 comment
Assignees
Labels
Type: Bug A problem with existing functionality

Comments

@AttackOnMorty
Copy link
Member

AttackOnMorty commented Jan 17, 2024

Hi team,

Based on the email chain:

From: @GordonBeeming
Date: Tuesday, 16 January 2024 at 16:36
To: @AttackOnMorty
Cc: @adamcogan, @jimmidier, @william-liebenberg
Subject: Sophie Bot - Seems to be broken at the moment

Describe the Bug

The two queries below are not working.

  • When asking “Who is in the Brisbane office?”, should return people working in the Brisbane office
  • When asking “Who is in the Brisbane office today?” (when asking time range), it should return the people connected to the WiFi today

Tasks

  • Investigate
  • Fix

Acceptance Criteria

Screenshots

Image
Figure: Should return people works in Brisbane

Image
Figure: Should return people in the office today

Thanks!

@AttackOnMorty AttackOnMorty added the Type: Bug A problem with existing functionality label Jan 17, 2024
@AttackOnMorty AttackOnMorty self-assigned this Jan 17, 2024
@AttackOnMorty AttackOnMorty changed the title 🐛 Fix UniFi related queries 🐛 Fix UniFi Related Queries Jan 17, 2024
@AttackOnMorty AttackOnMorty changed the title 🐛 Fix UniFi Related Queries 🐛 Fix query - Who is in the Brisbane office? May 13, 2024
@AttackOnMorty AttackOnMorty changed the title 🐛 Fix query - Who is in the Brisbane office? 🐛 Fix UniFi related queries May 13, 2024
@AttackOnMorty
Copy link
Member Author

AttackOnMorty commented May 13, 2024

✅ Done

For the query - "who is in the Brisbane office?", the bug is being fixed.

Image

For the query - "who is in the Brisbane office now?", it does query the data with data range. The problem is the response message for no one is found. With "at this time", it seems to check if people are in the office now.

So I changed the response message to reduce misunderstanding.

From

I couldn't find anyone in the Brisbane office at this time.

To

I couldn't find anyone in the Brisbane office.

Image
Figure: Enhanced message when no one is found

Image
Figure: Response is correct if people exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug A problem with existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant