Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IX_Messages_Position is redundant #287

Open
michael-freidgeim-webjet opened this issue Jun 30, 2019 · 2 comments
Open

IX_Messages_Position is redundant #287

michael-freidgeim-webjet opened this issue Jun 30, 2019 · 2 comments

Comments

@michael-freidgeim-webjet

Microsoft Azure Performance shows recommendation to delete index:
Reason | Duplicate index
Duplicate index name | IX_Messages_Position
Original index name | PK_Events
Indeed https://github.com/SQLStreamStore/SQLStreamStore/blob/master/src/SqlStreamStore.MsSql/ScriptsV3/CreateSchema_v2.sql
has
CREATE TABLE dbo.Messages(
... CONSTRAINT PK_Events PRIMARY KEY NONCLUSTERED (Position),
and
CREATE UNIQUE NONCLUSTERED INDEX IX_Messages_Position ON dbo.Messages (Position);

So IX_Messages_Position should be removed from the script.

@damianh
Copy link
Member

damianh commented Jul 11, 2019

Thanks for the report. The schema for MsSqlV3 (in version 1.2) is locked. I'll look to incorporate this in next version.

@MNF
Copy link
Contributor

MNF commented Jun 18, 2022

It seems that the whole file https://github.com/SQLStreamStore/SQLStreamStore/blob/master/src/SqlStreamStore.MsSql/ScriptsV3/CreateSchema_v2.sql is not used anymore and can be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants