Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADIOS is changing the debug mode #816

Open
lsawade opened this issue Mar 30, 2023 · 1 comment
Open

ADIOS is changing the debug mode #816

lsawade opened this issue Mar 30, 2023 · 1 comment

Comments

@lsawade
Copy link
Contributor

lsawade commented Mar 30, 2023

The most recent version of adios2 on github is causing a compilation error because the adios2_debug_mode_on/off mode flag is deprecated.

The fix would be

! Create adios handler passing the communicator, debug mode and error flag
! adios2 duplicates the communicator for its internal use
call adios2_init(myadios2_obj, comm_adios, ier)
if (ier /= 0) stop 'Error setting up ADIOS2: calling adios2_init() routine failed'

to replace the older

 if (USE_ADIOS2_DEBUG_MODE) then
    call adios2_init(myadios2_obj, comm_adios, adios2_debug_mode_on, ier)
  else
    call adios2_init(myadios2_obj, comm_adios, adios2_debug_mode_off, ier)
  endif
  if (ier /= 0) stop 'Error setting up ADIOS2: calling adios2_init() routine failed'

I'm hesitant to make a pull request, because it will break specfem for a current installations of ADIOS2. Another fix would be to check which adios version is being used and the do either.

@danielpeter
Copy link
Contributor

thanks Lucas for pointing out! I'll update the init routine together with some other updates I had to do anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants