Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ImGui a git submodule of ImGui-SFML #81

Open
eliasdaler opened this issue May 15, 2019 · 2 comments
Open

Make ImGui a git submodule of ImGui-SFML #81

eliasdaler opened this issue May 15, 2019 · 2 comments

Comments

@eliasdaler
Copy link
Contributor

I think it'll be good to pin specific ImGui commit (I'll use release ones in "master" and releases) and allow to not specify IMGUI_DIR, but get ImGui from subrepository and be sure that the version you'll be using was tested with ImGui-SFML.

@RichardDally
Copy link

It brings more complexity for almost no gain, I prefer cloning imgui separately on my own.

@Alia5
Copy link
Contributor

Alia5 commented Jan 11, 2023

I guess you mean submodule?
Careful with the wording here 😅

In any case, I'd strongly argue for a submodule instead of git-subtree or subrepo and make sure that the path of ImGUI is configurable.
So don't take IMGUI_DIR away, but provide a default for a (may or may not) cloned submodule.

This way, folks who want to manually manage ImGUI can do so; For other folks, the submodule should be enough and works out of the box.

@eliasdaler eliasdaler changed the title Make ImGui a subrepo of ImGui-SFML Make ImGui a git submodule of ImGui-SFML Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants