Add private conversion utilities between corresponding C and C++ data types

[ChrisThrasher]

CSFML/src/SFML/Graphics/RenderWindow.cpp

Lines 194 to 198 in fb9b3ae

	sf::Vector2i sfmlPos = renderWindow->This.getPosition();
	position.x = sfmlPos.x;
	position.y = sfmlPos.y;
	return position;

A common pattern in the implementation of the library is that we have two stack variables that represent the same thing but one type is from the sf:: namespace and the other is a CSFML public data type. Having both variables coexist leads to awkward variable names and requires rewriting the same logic to convert one type to another in many places.

I propose we add function overloads that convert between CSFML and SFML data types, in particular conversions from SFML to CSFML types which seems to be a more common.

sfVector2i toCType(const sf::Vector2i& vector)
{
    sfVector2i vector = {vector.x, vector.y};
    return vector;
}

The above snippet from RenderWindow.cpp would become a one-liner.

 return toCType(renderWindow->This.getPosition());

[eXpl0it3r]

Can we rely on the compiler to inline effectively or do we have to consider potential additional indirections & copies?

[ChrisThrasher]

https://en.cppreference.com/w/cpp/language/copy_elision

C++17's copy elision rules mean I don't think this would add any copies.