Convert private C++ headers to .hpp file extension #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisThrasher
force-pushed
the
hpp_headers
branch
from
e521a28
to
b939e82
Compare
|
This makes it really tricky to differentiate between CSFML headers and SFML headers next to each other. Like this: |
|
CSFML ought to use a |
|
I guess for CSFML 3 it's okay to move everything to |
Here's a patch that changes the SFML/ directory prefix to CSFML/. If you like this I'll submit a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #208
These are C++ source code files. To be consistent with SFML they should use an .hpp extension. This also has the benefit of making it easier to readers to understand whether a given file contains C or C++ code.