Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-li-notification-group]: Focus is trapped #8768

Open
1 task done
LidiyaGeorgieva opened this issue Apr 16, 2024 · 1 comment · May be fixed by #8969
Open
1 task done

[ui5-li-notification-group]: Focus is trapped #8768

LidiyaGeorgieva opened this issue Apr 16, 2024 · 1 comment · May be fixed by #8969
Assignees
@dimovpetar
Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
Maintenance - Topic RD

Comments

@LidiyaGeorgieva
Copy link
Contributor

Bug Description

See the steps to reproduce

Affected Component

No response

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

  1. open https://sap.github.io/ui5-webcomponents/storybook/playground/fiori/pages/NotificationListGroupItem/?sap-ui-theme=sap_fiori_3
  2. find to "Payments" group
  3. click the second list item
  4. press "arrow up" on the keyboard
  5. try to press "arrow up" or "arrow down"
  6. focus is trapped (can be moved only with "tab", but not with the arrows)

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

main

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@LidiyaGeorgieva LidiyaGeorgieva added the bug This issue is a bug in the code label Apr 16, 2024
@dimovpetar dimovpetar self-assigned this Apr 16, 2024
@dimovpetar
Copy link
Contributor

dimovpetar commented Apr 16, 2024 •
edited

Hello @SAP/ui5-webcomponents-topic-rd ,

ui5-busy-indicator intercepts all keydown and keyup events and stops their propagation. This is the reason why the focus stays trapped at the busy notification list item.
Besides keyboard, you also can't focus the busy item with the mouse, because the busy indicator adds pointer-events: none style.

Best regards,
Petar

@dimovpetar dimovpetar removed their assignment Apr 16, 2024
@dimovpetar dimovpetar added this to New Issues in Maintenance - Topic RD via automation Apr 16, 2024
@dimovpetar dimovpetar moved this from New Issues to In Progress in Maintenance - Topic RD Apr 24, 2024
@dimovpetar dimovpetar self-assigned this Apr 24, 2024
dimovpetar added a commit that referenced this issue Apr 24, 2024
@dimovpetar
fix(ui5-notification-list-item): busy item no longer traps focus
1dbe6f1 
Fixes: #8768
@dimovpetar dimovpetar mentioned this issue Apr 24, 2024
Closed
@dimovpetar dimovpetar linked a pull request May 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimovpetar dimovpetar

Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
Maintenance - Topic RD
  
In Progress
Milestone
No milestone
2 participants
@LidiyaGeorgieva @dimovpetar