Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TimePicker]: glowing box-shadow around the input field #8932

Closed
1 task done
ilhan007 opened this issue May 10, 2024 · 1 comment · Fixed by #8951
Closed
1 task done

[TimePicker]: glowing box-shadow around the input field #8932

ilhan007 opened this issue May 10, 2024 · 1 comment · Fixed by #8951
Assignees
@unazko
Labels
bug This issue is a bug in the code TOPIC B
Projects
Maintenance - Topic B

Comments

@ilhan007
Copy link
Member

ilhan007 commented May 10, 2024 •
edited

Bug Description

All other inputs don't have such glowing box-shadow as the Timepicker, so I assume it's wrong or if not - all the other inputs are wrong.

TimPicker:
Screenshot 2024-05-10 at 9 21 50

DateTimPicker:
Screenshot 2024-05-10 at 9 24 30

Affected Component

ui5-timepicker

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

  1. Open https://sap.github.io/ui5-webcomponents/nightly/components/TimePicker/#format-patterns

...

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

latest

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@ilhan007 ilhan007 added bug This issue is a bug in the code TOPIC B labels May 10, 2024
@ilhan007 ilhan007 added this to New Issues in Maintenance - Topic B via automation May 10, 2024
@ilhan007
Copy link
Member Author

fwi @SAP/ui5-webcomponents-topic-b - visual issue, but very noticeable when the timepicker is used among other inputs.

@ilhan007 ilhan007 changed the title [Timepicker]: glowing box-shadow around the input field [TimPicker]: glowing box-shadow around the input field May 10, 2024
@unazko unazko self-assigned this May 11, 2024
@unazko unazko moved this from New Issues to In Progress in Maintenance - Topic B May 11, 2024
@unazko unazko mentioned this issue May 13, 2024
Merged
@unazko unazko changed the title [TimPicker]: glowing box-shadow around the input field [TimePicker]: glowing box-shadow around the input field May 15, 2024
Maintenance - Topic B automation moved this from In Progress to Completed May 18, 2024
unazko added a commit that referenced this issue May 18, 2024
@unazko
fix(ui5-time-picker): remove box shadow (#8951)
7c7170d 
Fixes: #8932
unazko added a commit to unazko/ui5-webcomponents that referenced this issue May 19, 2024
@unazko
fix(ui5-time-picker): remove box shadow
5364168 
Fixes: SAP#8932
@unazko unazko mentioned this issue May 19, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unazko unazko

Labels
bug This issue is a bug in the code TOPIC B
Projects
Maintenance - Topic B
  
Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-time-picker): remove box shadow unazko/ui5-webcomponents
2 participants
@ilhan007 @unazko