Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discovery of DataVerticle metrics #253

Open
1 task done
s4heid opened this issue Feb 8, 2023 · 0 comments
Open
1 task done

Improve discovery of DataVerticle metrics #253

s4heid opened this issue Feb 8, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@s4heid
Copy link
Contributor

s4heid commented Feb 8, 2023

Is there an existing issue for this?

  • I have searched the existing issues

The Problem

There is 4 different data verticle metrics that can be enabled. These metrics will be collected for every single DataVerticle if the feature is enabled.

This may be fine for small installations, but running NeonBee with a large number of DataVerticles will produce a huge amount of metrics and clutter the monitoring system.

Desired Solution

Two ideas to improve the discovery of the metrics:

  • instead of making the verticle name part of the metric name, a micrometer tag could be used. this would reduce the number of metrics to 4, but you would still be able to filter for a specific verticle (e.g. when creating a chart).
  • add a neonbee. prefix to each metric. The monitoring system might contain quite a lot of metrics from different sources with overlapping names. The prefix would make it easier to search for the neonbee metrics, if you don't recall the exact name. This should be a convention for all metrics sent by neonbee.

Alternative Solutions

No response

Additional Context

No response

@s4heid s4heid added the enhancement New feature or request label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant