Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky backwards compatibility test #3724

Closed
JohannesDoberer opened this issue May 14, 2024 · 4 comments
Closed

Flaky backwards compatibility test #3724

JohannesDoberer opened this issue May 14, 2024 · 4 comments
Assignees
@hardl
Labels
internal Stuff like NFRs, CI pipeline ora ora related issues

Comments

@JohannesDoberer
Copy link
Contributor

JohannesDoberer commented May 14, 2024 •
edited

Logout and login again is failing sometimes if a pr get's merged.
https://github.com/SAP/luigi/actions/runs/9062391595/job/24896282753

Log:

 Login Flow
    ✓ User name in profile dropdown (1499ms)
    ✓ Link in profile dropdown (2455ms)
    ✓ Change title and logo (1154ms)
    1) Logout and login again

  TopNavDropDown
    Desktop
      ✓ Clicking around drop down in TopNav (636ms)
    Mobile
      ✓ Should be able to select product (464ms)
      ✓ Should be able to close (475ms)


  6 passing (12s)
  1 failing

  1) Login Flow
       Logout and login again:
     AssertionError: Timed out retrying after 4000ms: expected '<body>' to contain 'Login to Luigi sample app'
      at Context.eval (webpack:///../e2e/tests/1-angular/login-flow-nav-dropdown.cy.js:81:19)




  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        7                                                                                │
  │ Passing:      6                                                                                │
  │ Failing:      1                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  1                                                                                │
  │ Video:        false                                                                            │
  │ Duration:     12 seconds                                                                       │
  │ Spec Ran:     login-flow-nav-dropdown.cy.js                                                    │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


  (Screenshots)

  -  /home/runner/work/luigi/luigi-compatibility-testing/test/e2e-test-application/cy     (1280x633)
     press/screenshots/login-flow-nav-dropdown.cy.js/Login Flow -- Logout and login a               
     gain (failed).png
@JohannesDoberer JohannesDoberer added the internal Stuff like NFRs, CI pipeline label May 14, 2024
This was referenced May 14, 2024
Merged
Closed
@JohannesDoberer
Copy link
Contributor Author

Maybe a cache issue, because after deleting the cache it is green.

@hardl hardl changed the title Flacky backwards compatibility test Flaky backwards compatibility test May 15, 2024
@Jotrorox
Copy link
Contributor

Jotrorox commented May 16, 2024 •
edited

Hey @JohannesDoberer,
Should I wait continuing to commit till this project is resolved, since I thought about tackling a few more code intensive tasks and that could become complicated if one of the tests always fails on me? Obviously only if that is wanted

Best Regards

Johannes

@JohannesDoberer
Copy link
Contributor Author

Hey @Jotrorox,
You can still contribute to the Luigi project. It is not your fault.
We will start investigating this issue soon.
Also, if it fails again, I will just re-run the failed job (if it is this logout and login again test).
So... no worries and feel free to contribute.

Cheers,
Johannes

@JohannesDoberer JohannesDoberer self-assigned this May 17, 2024
@Jotrorox
Copy link
Contributor

Jotrorox commented May 17, 2024 •
edited

It seems to not only be a thing with my commits as seen here: 53e757d, but that one plus my commits are the only times this seems to have occured.

@JohannesDoberer JohannesDoberer removed their assignment May 27, 2024
@hardl hardl self-assigned this May 28, 2024
@hardl hardl added the ora ora related issues label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hardl hardl

Labels
internal Stuff like NFRs, CI pipeline ora ora related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hardl @JohannesDoberer @Jotrorox