Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust docu generation to not trigger on all container changes #3708

Closed
ndricimrr opened this issue Apr 22, 2024 · 0 comments · Fixed by #3728
Closed

Adjust docu generation to not trigger on all container changes #3708

ndricimrr opened this issue Apr 22, 2024 · 0 comments · Fixed by #3728
Assignees
Labels
good first issue Good for newcomers internal Stuff like NFRs, CI pipeline

Comments

@ndricimrr
Copy link
Contributor

ndricimrr commented Apr 22, 2024

When trying to add new tests to /container the docu generation is being ran each time here.

Docu generation should only be triggered when only the relevant container docu parts are affected.

Figure out which parts/files of /container folder are used for the docu generation part and only trigger docu generation when they are changed. Currently it is triggered on all changes.

Relevant change to be made is most likely here:

staged_changes=$(git diff --cached --name-only --diff-filter=ACM | grep -e "core/src/core-api" -e "client/src" -e "container"| wc -l)

@ndricimrr ndricimrr added good first issue Good for newcomers internal Stuff like NFRs, CI pipeline labels Apr 22, 2024
@walmazacn walmazacn self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers internal Stuff like NFRs, CI pipeline
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants