Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate extracting common Core/Client functionality in favour of reusability #3651

Open
ndricimrr opened this issue Feb 15, 2024 · 0 comments
Labels
refactoring Something needs to be refactored in a separate task

Comments

@ndricimrr
Copy link
Contributor

Some parts of Luigi Core/Client are some times shared with Luigi Container.

Investigate and come up with a strategy to have a common shared folder where multiple packages use the same implementation if possible/feasible

Topics to start with:

  1. Web Component Creation Code is very similar (Core-Container) (if not almost identical)
  • core/src/web-components.js
  • container/src/services/webcomponents.service.ts
    Might be worth to have both Core and Container use the same code base for this functionality.
  1. Luigi Client API - Container Client API
  • createClientAPI function on Container for webcomponents is supposed to emulate the Luigi Client API. Since they are very similar it might be worth investigating what functionality could be shared

... other ideas that might come up

Another requirement is that this change would have us switch all core/client code from JS to Typescript.

New proposed folder structure

core/
client/
container/
common/    <----- this could be one way to save the shared common functionality
@ndricimrr ndricimrr added the refactoring Something needs to be refactored in a separate task label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Something needs to be refactored in a separate task
Projects
None yet
Development

No branches or pull requests

1 participant