Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsure how to run as react-native-windows #31

Open
majorgreys opened this issue Jul 26, 2017 · 4 comments
Open

Unsure how to run as react-native-windows #31

majorgreys opened this issue Jul 26, 2017 · 4 comments

Comments

@majorgreys
Copy link

Given #9 and #10 I expected the demo to have the option to build using the react-native windows support, but it seems that package.json no longer contains the react-native-windows dependencies. What changes? What should be run to build it?

@majorgreys
Copy link
Author

It seems the relevant lines in package.json were removed by a latter commit ddd2c36

@forki
Copy link
Member

forki commented Jul 26, 2017

I had to remove because we had to upgrade react native and it didn't match versions. Maybe it's fine now. I'm open for pull requests

@ctaggart
Copy link
Contributor

This issue is referring to https://github.com/Microsoft/react-native-windows? Not sure that dependency needs to be in this demo app.

@forki
Copy link
Member

forki commented Mar 21, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants