Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary character length should be enforced #2

Open
flaki opened this issue Nov 1, 2021 · 2 comments
Open

Summary character length should be enforced #2

flaki opened this issue Nov 1, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@flaki
Copy link
Contributor

flaki commented Nov 1, 2021

Currently the character length limit of the CFP summary is stated, but not enforced, and it should be.

It should probably also be configurable.

@flaki flaki added the bug Something isn't working label Nov 1, 2021
@flaki
Copy link
Contributor Author

flaki commented Nov 1, 2021

One difficulty of this is currently fields used by the form (and constraints such as whether they are required) are stored on the backend in a hardcoded structure. We should make this configurable via the UI. Either way, we will need to figure out how to encode these constraints into the structure. One idea is:

  *language
   presentation_lang
  *presentation_format
  *title
  *summary(maxlen:240)
  *description
  ...

In the above case we add (maxlen:240) after the property name, which is a simple list of key-value pairs that could then be interpreted as constraints by the clientside CFP App, as well as the backend verification.

(Note: in the structure the *-s represent the required fields)

@flaki
Copy link
Contributor Author

flaki commented Nov 2, 2021

Since version cfp-app 1.1.4 we warn about exceeding the Summary field length, but this is a one-off hardcoded check (and for now we do not enforce the length limitation on either the client or serverside).

CFP field content length warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant