Dual versions for parallel #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks @27pchrisl this could very well be a solution but we may have to make some changes to the code itself. See the failed test here https://github.com/RubixML/ML/actions/runs/9035283567/job/24858504227?pr=332 and let me know what you think. Thanks again! |
|
Hiya @andrewdalpino, I created an |
|
I could implement a common abstract class, but it would only really abstract away the constructor and the __toString method, so I have created them completely separately. |
|
Unfortuantely we don't have the resources to support this at this time. Will look to upgrading to Amp Parallel 2.2 in ML 3.0. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @andrewdalpino,
To resolve #305 is it suitable to dual-require parallel versions 1.3 and 2.2, and let Composer choose the right one based on your PHP version?