Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dust that is left over from "Max" trades better #25

Open
bghughes opened this issue Oct 21, 2021 · 0 comments
Open

Handle dust that is left over from "Max" trades better #25

bghughes opened this issue Oct 21, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@bghughes
Copy link
Contributor

Presently, users trading on Rubicon can have leftover "dust" from transactions in their wallets. This represents a small amount of wei (usually a 1 at the last decimal place) - it is most apparent on "Max" trades in which a user wants to trade all of their tokens in a swap, for example.

This is annoying from a UX perspective and an on-chain solution should be implemented to handle dust better. I see two paths that could offer solutions:

  1. Add max function wrappers that take a user's entire balance of whatever token they are trading and handles dust logic
  2. Pool user dust somewhere that is not the user wallet after the transaction
@bghughes bghughes added the bug Something isn't working label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant