Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Star Wars Saga Edition] Several fixes of varying types #10617

Open
LilLiteralist opened this issue May 27, 2022 · 4 comments
Open

[Star Wars Saga Edition] Several fixes of varying types #10617

LilLiteralist opened this issue May 27, 2022 · 4 comments

Comments

@LilLiteralist
Copy link
Contributor

LilLiteralist commented May 27, 2022

I'm not sure if these should be submitted as separate issues, but some of these things have been driving me nuts for awhile. Some are more recent.

EDIT: At this point, I have fixed all of the original issues. There are still the issues in the comments, though.

  1. With the addition of the Second Wind stuff, the spacing is a bit cramped with the radio buttons under Condition. This is the default spacing when the sheet is opened.
    image
  2. Right now, attr_damage_max adds half the character level (which is in @{level|max} and factors in nonheroic levels). This should be changed to half the heroic level (which is currently found in @{level}), rounded down.
  3. The checkbox for "Dex score as decimal" should actually use "Initiative modifier as decimal," since that is the method for breaking ties in this system.
  4. Since droids do not have a Con score, it would be good if we can have that represented on the sheet as an entry of "-". The modifer would need to be set to 0 in that case. This could be worked around easily by just putting in a score of 10, but the new Use Second Wind button does not take into account that droids will never use their Constitution score.
  5. There's a checkbox for double carrying capacity, but this doesn't come into play very often. A 2x modifier can come from a particular 5th degree droid talent (unused in any statblock and unavailable to anyone but the right type of droid) or from low gravity. High gravity has a carrying capacity of 0.5x normal, and zero gravity has a carrying capacity of 10x normal, but changes in gravity are not common in this system. A far more used modifier is 1.5x from Extra Legs, which is still limited to droids, but at least available to every type of droid and is actually used in official statblocks. Just changing this to 1.5x modifier would be better than it is currently. I don't know if taking gravity or that one droid talent into account is worth putting in other options.
  6. Once a PC hits level 10, Armored Defense (without Improved Armored Defense) will only calculate correctly if the armor bonus to Ref is 0 or 1. Once the PC hits level 20, it will also calculate correctly if the armor bonus to Ref is 0, 1, or 2. And if you put in level 30, it's good for an armor bonus of 0-3.
    image
    This is where the issue is, though I have no idea why it only seems to be using the first digit of the level's value.
@LilLiteralist
Copy link
Contributor Author

LilLiteralist commented May 27, 2022

Oh, and fix "Encumberance" to "Encumbrance"

@LilLiteralist
Copy link
Contributor Author

LilLiteralist commented May 17, 2023

I've managed to fix most of these issues myself, though I've found a host of others as well.

  1. Make the print function not look like a hot mess.
  2. Add support for translation in the sheet. (Lots of data-i18n)
  3. Make sure mouseover text has variable names that can be called in macros
  4. Status button below Perception and Initiative which sends combat-relevant statistics to chat.
  5. Vehicle skills need fixing, sometimes using the Pilot modifier if trained, and sometimes using the higher of Pilot and the skill.
  6. Relocate the [hide/show] toggle for attacks, so that it isn't behind the trash can when the repeating sections are being modified.
  7. Add a spot on the NPC sheet for armor.
  8. Ability to select default skill crews in vehicle sheet
  9. Remove the armor's Helmet Package bonus to Perception if the character is not proficient.

@nmbradley
Copy link
Collaborator

@LilLiteralist are these issues still outstanding, following the work on the sheet?

@LilLiteralist
Copy link
Contributor Author

@nmbradley Most of it has been resolved, although I could certainly add more things that this sheet would benefit from. Is there a better place to keep track of standing issues with the sheet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants