Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Peak interval for the HashKeys #2524

Open
ghost opened this issue Mar 6, 2018 · 2 comments
Open

More Peak interval for the HashKeys #2524

ghost opened this issue Mar 6, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Mar 6, 2018

Expected Behavior

For example on the Status page, you can see the peak that has occurred in the last 5/15/30/60/sinceStart minutes.

Current Behavior

Currently, you can only see the peak that has been occurring since the start. The peak can be less then usually, because perhaps no more accounts are logged in. So you see better if you can use a lower-level HashKey.

Possible Solution

A list in which one can select one or more intervals.

Steps to Reproduce (for bugs)

Context

Your Environment

@sebastienvercammen
Copy link
Member

sebastienvercammen commented Mar 6, 2018

Look at that, a shiny new "to be discussed" label just for you! 😊

There are two sides to the "peak" story so far:

  1. Yours. You want to see the peak related to a certain period of time rather than the peak since startup.
  2. The people who consider the peak to be the highest point of all usage - this implies "since startup".

Group 2 says that "peak" should stay the highest since startup, because our "usage" is an average usage based on 60 samples that we've taken. So even if you instantly hit the peak at startup, the sampled usage per minute won't be 150 after the first minute, and the sampled usage can be used as a measure for how much wiggle room you still have.

Additionally, RocketMap automatically retries requests (including an appropriate, minor pause to allow usage to decrease thanks to #2535 it now sleeps the perfect amount of time until RPM becomes available) that have failed because you exceeded your hashing quota (RPM), making it no problem to temporarily exceed your RPM.

I've pinged the RM team to join in the discussion and post their opinions if they'd like.

@Alderon86
Copy link
Contributor

Imho i think we dont need another peak, it would sit around the same value as usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants