Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global search - cannot go to message in a diff channel #32231

Open
paulharris opened this issue Apr 17, 2024 · 11 comments
Open

Global search - cannot go to message in a diff channel #32231

paulharris opened this issue Apr 17, 2024 · 11 comments

Comments

@paulharris
Copy link

Description:

Go to a channel (or chat).
Click search.
Turn on global switch.
Type some text that you know will give messages in a different channel.
Click "Go to message" next to that message.
Observe "Room not found" screen, which says "The room does not exist or you may not have access permissions".

Then, go to that different channel manually.
Open Search, do the same search. NOW you can goto that message.

Server Setup Information:

  • Version of Rocket.Chat Server: 6.6.5
  • Operating System: Linux
  • Deployment Method: tar
  • Number of Running Instances: 1
  • DB Replicaset Oplog: uhhhh
  • NodeJS Version: 14.21.3
  • MongoDB Version: 6.0.14

Client Setup Information

  • Desktop App or Browser Version: Firefox
  • Operating System: Linux
@Gummikavalier
Copy link

I cannot reproduce on RC 6.6.6. Probably has some particular condition to fulfill until it triggers.

@paulharris
Copy link
Author

I have a group called #support with a message inside, with the word "silly".
the url is https://myhost/group/support

If i go to the channel named #bugs and search for "silly" (global), trying to go to the message gives me "Room not found".
Note that #bugs is https://myhost/channel/bugs

If I instead start in a private chat with person-1, then try again, I get "Room not found" (the URL is https://myhost/direct/hashhashhash/...)

If I start in a group called Translations, and then search, it works,
this time the group is https://myhost/group/translations

So the problem appears to be that the target URL does not change the base type (ie channel, group, direct, ...)

Also, isn't nice that the search-results disappear when I jump to the message.
If it isn't what I'm looking for, I have to start the search from scratch.

@Gummikavalier
Copy link

Thanks! I still cannot replicate the issue. I tried and in these scenarios the global search as well as jumping to those messages work for us ok.

"Room not found" issues often have indicated cached channels when we've met them, and for clearing out those logging out and logging back in usually helps (the channel subscriptions get loaded again).

@paulharris
Copy link
Author

This happens to me in a private firefox window, no cache.

Did you try looking for a message that exists in a private 'group', while in another 'channel' or PM ?
Of course while you are a member of the private group.

@Gummikavalier
Copy link

Hi, yes, I tried. Global search works without issues for us. 😥

@Gummikavalier
Copy link

Gummikavalier commented Apr 29, 2024

Oh! Additional note; have you enabled Global search under /admin/settings/Search -> Default provider?

We have that on.

@paulharris
Copy link
Author

I have global-search enabled.
Perhaps it is because I had enabled it earlier when it was still in beta?

@Gummikavalier
Copy link

We've had it enabled too during the beta times. It's getting weird... 😞

@reetp
Copy link

reetp commented May 10, 2024

I think this may be related to messages found that are in a thread?

If I search for text and it is a standard message it seems OK, but if I search for a message that is in a thread the URL seems wrong.

This is the search result (and the link in the code, less the https://my.domain.com/) whilst in a private room for a result in a public room - this shows 'Room not found':

https://my.domain.com/group/publictest/thread/iqL5ZJh3jX4ZrqurD?msg=joTnD4e6NF7GhTy2T

This is the link if you copy it from 'Copy link' in the message

https://my.domain.com/channel/publictest?msg=joTnD4e6NF7GhTy2T

@paulharris
Copy link
Author

I can confirm that the message I was trying to jump to was in a thread !

@reetp
Copy link

reetp commented May 18, 2024

This is in the queue to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants