Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cpp20 #1920

Open
kfu02 opened this issue Jul 7, 2022 · 0 comments
Open

Upgrade to cpp20 #1920

kfu02 opened this issue Jul 7, 2022 · 0 comments

Comments

@kfu02
Copy link
Contributor

kfu02 commented Jul 7, 2022

we should make all of these is_done methods also constexpr. You cannot make virtual functions constexpr in cpp17 which we use right now, but when I switched to cpp20, this change worked. Marking as constexpr offloads all the work to compile time. Since doing this requires changing our cpp version, we can do it in a different pr if you want. I still think it should be done at some point.

Originally posted by @kasohrab in #1911 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant