Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle invisibility of a file in the view #74

Open
Pipe-to-Grep opened this issue Nov 15, 2018 · 4 comments
Open

Toggle invisibility of a file in the view #74

Pipe-to-Grep opened this issue Nov 15, 2018 · 4 comments

Comments

@Pipe-to-Grep
Copy link

Rather than only being able to uncheck categories (code, misc, markup, etc.), we should be able to right click a file and toggle its visibility

@Rob--W
Copy link
Owner

Rob--W commented Nov 16, 2018

A checkbox is reversible. If right-clicking on a file name hides the file, then it is not possible to see the file again if it was hidden by accident.

What's your use case for this feature?

@Pipe-to-Grep
Copy link
Author

I want to be able to make a file invisible after reviewing it. I suppose a better way of going about it would be setting it up to be possible to assign a file to a category (and create new cats).

@Rob--W
Copy link
Owner

Rob--W commented Nov 16, 2018

I suppose that adding an option to tag a file based on file hash, and a way to filter by it would be useful. It can also be a general method that solves #36.

A general solution could however result in a too complicated UI: Currently all categories are disjoint (i.e. have no overlapping definitions), so it is easy to show or hide specific categories. With an arbitrary number of tags, the meaning of additional category checkboxes become non-intuitive (there is a need to filter or hide by tag, and potentially a combination of tags).

To address that, I think that I would be supportive of a way to define new tags (andor have a pre-existing set of tags such as "dangerous", "whitelisted", "untagged"), but only allow a file to have one tag. This feature could be made available as a right-click option on a file name, and/or be shown at the Analysis button (where the file hash is shown).

@Pipe-to-Grep
Copy link
Author

That sounds great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants