Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraAttributes should nest #330

Open
ZevEisenberg opened this issue Mar 19, 2018 · 0 comments
Open

extraAttributes should nest #330

ZevEisenberg opened this issue Mar 19, 2018 · 0 comments

Comments

@ZevEisenberg
Copy link
Collaborator

case let .extraAttributes(attributes):
    self.extraAttributes = attributes

Instead of just assigning, we should merge the attributes so that any shared keys in the right-hand side overwrite those keys in the left-hand side.

Question: any way to un-set custom attributes in the left-hand side by passing something in the right-hand side? Or should we just assume that the developer will pass some sentinel value like NSNull()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant