Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrganelleOpaque shader dissolve animation doesn't work #5043

Open
hhyyrylainen opened this issue Apr 17, 2024 · 3 comments
Open

OrganelleOpaque shader dissolve animation doesn't work #5043

hhyyrylainen opened this issue Apr 17, 2024 · 3 comments

Comments

@hhyyrylainen
Copy link
Member

When upgrading things for Godot 4 I noticed that that shader variant doesn't really work with the dissolve animation, only the transparent shader variant does.

@hhyyrylainen hhyyrylainen added this to Features for next release in Thrive Planning Apr 17, 2024
@hhyyrylainen hhyyrylainen moved this from Features for next release to Low priority bugs / issues in Thrive Planning Apr 17, 2024
@GameDungeon
Copy link
Contributor

GameDungeon commented Apr 29, 2024

I looked into this. As far as I can tell, the dissolve animation has never worked with the OrganelleOpaque shader. I played some older pre-godot4 versions to check. As far as I can tell, the fix for this issue is just using the organelle transparent shader everywhere. It seems to fix the issue without creating any more I can see, but I am suspicious because they had to have been separated for a reason.

@hhyyrylainen
Copy link
Member Author

the dissolve animation has never worked with the OrganelleOpaque shader

I suspected this as well, but apparently I didn't write in the original issue description.

It seems to fix the issue without creating any more I can see, but I am suspicious because they had to have been separated for a reason.

The transparent shader caused some really nasty organelle geometry being visible through itself with internal parts being drawn on top of the parts they should have been inside of.

@GameDungeon
Copy link
Contributor

The transparent shader caused some really nasty organelle geometry being visible through itself with internal parts being drawn on top of the parts they should have been inside of.

Interestingly, my attempt to make the OrganelleOpaque work led to this. It appears that it no longer happens by default in the transparent shader, as swapping to that fixed the overdraw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Low priority / might do
Thrive Planning
  
Low priority bugs / issues
Development

No branches or pull requests

2 participants