Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retroarch failing to build on clean ubuntu noble install #3915

Open
theofficialgman opened this issue May 2, 2024 · 7 comments
Open

retroarch failing to build on clean ubuntu noble install #3915

theofficialgman opened this issue May 2, 2024 · 7 comments

Comments

@theofficialgman
Copy link
Contributor

input/drivers/udev_input.c:3855:14: warning: the comparison will always evaluate as ‘true’ for the pointer operand in ‘binds + (sizetype)((long unsigned int)port * 4272)’ must not be NULL [-Waddress]
 3855 |          if (binds[port])
      |              ^~~~~
CC gfx/drivers_context/gfx_null_ctx.c
CC gfx/common/gl_common.c
CC gfx/drivers/gl2.c
CC libretro-common/gfx/gl_capabilities.c
CC libretro-common/glsym/rglgen.c
CC gfx/drivers/gl1.c
CC gfx/drivers_context/vc_egl_ctx.c
gfx/drivers_context/vc_egl_ctx.c:24:10: fatal error: VG/openvg.h: No such file or directory
   24 | #include <VG/openvg.h>
      |          ^~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:209: obj-unix/release/gfx/drivers_context/vc_egl_ctx.o] Error 1
make: *** Waiting for unfinished jobs....
Could not successfully build retroarch - RetroArch - frontend to the libretro emulator cores - required by all lr-* emulators (/home/runner/RetroPie-Setup/tmp/build/retroarch/retroarch not found).

vc_egl shouldn't be even attempted to be built on non-raspberry pi systems. this is probably a mistake in the configuration parameters.

full buildlog https://github.com/cobalt2727/L4T-Megascript/actions/runs/8923983609/job/24509379849#step:3:2716

@cmitu
Copy link
Contributor

cmitu commented May 3, 2024

We don't set any configuration parameters for OpenVG, compilation is set to auto in the configure scripts. I don't think this is a RetroPie build issue, you may want to open this upstream or explicitely disable the openvg support in your scripts.

@mrcmunir
Copy link
Contributor

mrcmunir commented May 22, 2024

input/drivers/udev_input.c:3855:14: warning: the comparison will always evaluate as ‘true’ for the pointer operand in ‘binds + (sizetype)((long unsigned int)port * 4272)’ must not be NULL [-Waddress]
 3855 |          if (binds[port])
      |              ^~~~~
CC gfx/drivers_context/gfx_null_ctx.c
CC gfx/common/gl_common.c
CC gfx/drivers/gl2.c
CC libretro-common/gfx/gl_capabilities.c
CC libretro-common/glsym/rglgen.c
CC gfx/drivers/gl1.c
CC gfx/drivers_context/vc_egl_ctx.c
gfx/drivers_context/vc_egl_ctx.c:24:10: fatal error: VG/openvg.h: No such file or directory
   24 | #include <VG/openvg.h>
      |          ^~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:209: obj-unix/release/gfx/drivers_context/vc_egl_ctx.o] Error 1
make: *** Waiting for unfinished jobs....
Could not successfully build retroarch - RetroArch - frontend to the libretro emulator cores - required by all lr-* emulators (/home/runner/RetroPie-Setup/tmp/build/retroarch/retroarch not found).

vc_egl shouldn't be even attempted to be built on non-raspberry pi systems. this is probably a mistake in the configuration parameters.

full buildlog https://github.com/cobalt2727/L4T-Megascript/actions/runs/8923983609/job/24509379849#step:3:2716

The workarround it's use isPlatform on all tegra devices params+=(--disable-videocore --disable-vg) in retroarch.sh script .
It's broken by retroarch for a long time and i'm compile fine with force these flags

@cmitu
Copy link
Contributor

cmitu commented May 23, 2024

It's broken by retroarch for a long time and i'm compile fine with force these flags

Unless you report it upstream, the issue is not going to be fixed as is.

mrcmunir added a commit to mrcmunir/RetroArch that referenced this issue May 23, 2024
I don't recommend having this in auto mode as it will fail on various arm64 systems.
See RetroPie/RetroPie-Setup#3915
@mrcmunir
Copy link
Contributor

@theofficialgman try mrcmunir/RetroArch@0731ef8
If it's prevent compile vc_egl headers without pass disabled flags.

@theofficialgman
Copy link
Contributor Author

The workarround it's use isPlatform on all tegra devices params+=(--disable-videocore --disable-vg) in retroarch.sh script . It's broken by retroarch for a long time and i'm compile fine with force these flags

The CI I linked doesn't have device-tree available (as its a QEMU emulated chroot), so its just using the fallback platform provided here https://github.com/RetroPie/RetroPie-Setup/blob/master/scriptmodules/system.sh#L490 not any of the tegra specific flags.

@theofficialgman
Copy link
Contributor Author

@theofficialgman try mrcmunir/RetroArch@0731ef8 If it's prevent compile vc_egl headers without pass disabled flags.

I don't think that is the correct course of action. You should go through the logs and determine what is pulling in compilation of that file even when when OPEN_VG gets disabled from auto https://github.com/cobalt2727/L4T-Megascript/actions/runs/8923983609/job/24509379849#step:3:2763

@mrcmunir
Copy link
Contributor

@theofficialgman Probably found cause fail retroarch bcm_host_init fuction are found.
https://github.com/cobalt2727/L4T-Megascript/actions/runs/8923983609/job/24509379849#step:3:2729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants