Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeadLock iOS 12 #2544

Open
Brunz opened this issue Oct 11, 2018 · 2 comments
Open

DeadLock iOS 12 #2544

Brunz opened this issue Oct 11, 2018 · 2 comments

Comments

@Brunz
Copy link

Brunz commented Oct 11, 2018

RKManagedObjecyRequestOperation.m

Workaround: Call [contextToSave save:&localError]; on main thread

if (! [self isCancelled]) {
dispatch_async(dispatch_get_main_queue(), ^{
success = [contextToSave save:&localError];
if (! success && localError == nil) RKLogWarning(@"Saving of managed object context failed, but a nil value for the error argument was returned. This typically indicates an invalid implementation of a key-value validation method exists within your model. This violation of the API contract may result in the save operation being mis-interpretted by callers that rely on the availability of the error.");
});
} else {
// We have been cancelled while the save is in progress -- bail
success = NO;
}

@martias
Copy link

martias commented Oct 24, 2018

Would this fix the [RKManagedObjectRequestOperation obtainPermanentObjectIDsForInsertedObjects:]_block_invoke crash?

In that case, would it be worth creating a PR with this change?

martias added a commit to nedap/RestKit that referenced this issue Oct 31, 2018
martias added a commit to nedap/RestKit that referenced this issue Oct 31, 2018
* development:
  Applied fix from Brunz (RestKit#2544)
@roasted-almond
Copy link

Hi guys, is there any fork that uses latest AFNetworking as well?
Wondering how do you guys manage legacy projects which still using RestKit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants