Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pathFinder mode able to use n-length paths #9

Open
Reidmcc opened this issue Feb 7, 2019 · 3 comments
Open

Make pathFinder mode able to use n-length paths #9

Reidmcc opened this issue Feb 7, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@Reidmcc
Copy link
Owner

Reidmcc commented Feb 7, 2019

Describe the solution you'd like

I want to have pathFinder check n-length paths, instead of hard-coded three-asset paths as it does now.

Right now it does this path structure:

XLM ➡️ USD ➡️ EUR ➡️ XLM

With this feature it could also do, for example:

XLM ➡️ USD ➡️ EUR ➡️ CNY ➡️ XLM

Describe alternatives you've considered
This would be an adaptation of the n-path code that pathRequester already has; pathRequester itself was the alternative to pathFinder's current behavior but the rest of pathRequester didn't perform well.

Requirements

  • Change pathFinder's PaymentPath so it uses a list of pairs
  • Make MakePathPayment behave like makePathPaymentredux, but for rockfish's native structs instead of Horizon's json return
  • Update pathFinder's configuration to accommodate the changes
@Reidmcc Reidmcc added enhancement New feature or request good first issue Good for newcomers labels Feb 7, 2019
@Reidmcc Reidmcc added this to the 0.3.0-alpha milestone Feb 7, 2019
@Reidmcc Reidmcc removed the good first issue Good for newcomers label Feb 20, 2019
@Reidmcc Reidmcc self-assigned this Feb 20, 2019
@Reidmcc Reidmcc modified the milestones: 0.3.0-alpha, 0.4.0-alpha Feb 22, 2019
@Reidmcc Reidmcc added this to To do in 0.4.0-alpha Feb 27, 2019
@ilyacherevkov
Copy link

When I worked on my own triangular arbitrage bots, I implemented recursive algorithm to build any N-length sequence.

But then... I realised, it doesn't have any sense. All you need is 2 and 3 length sequences, because >=3 is just derivatives of 3

@ilyacherevkov
Copy link

ilyacherevkov commented Jun 9, 2019

But since Lumen allows N-length payment transactions, this could make sense to insta-capture additional margin...

My bots on waves dex were exposed to a great risk in 4+ steps transactions, because most of the time I ended up stuck in some low-liqudity coin, this may not be the case with Lumen.

@Reidmcc
Copy link
Owner Author

Reidmcc commented Jun 11, 2019

@ilyacherevkov yeah, it's the instant path-payment method that makes >3 step paths worth considering; risk stays at zero regardless of path length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
0.4.0-alpha
  
To do
Development

No branches or pull requests

2 participants