Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The v2.1.4 defines jest-environment-jsdom as prod dependency #2537

Open
piotr-cz opened this issue May 6, 2024 · 1 comment · May be fixed by #2543
Open

The v2.1.4 defines jest-environment-jsdom as prod dependency #2537

piotr-cz opened this issue May 6, 2024 · 1 comment · May be fixed by #2543

Comments

@piotr-cz
Copy link

piotr-cz commented May 6, 2024

Describe the bug
After upgrading @redocly/cli from 1.11.0 to 1.12.0 I've noticed lots of new dependencies.

Turns out that these are pulled along with jest-environment-jsdom, which has been added as a dependency instead of devDependency here: https://github.com/Redocly/redoc/pull/2445/files

Expected behavior
Installing @redocly/cli or redoc package in a project should not install dependencies related to tests such as jest

Minimal reproducible OpenAPI snippet(if possible)

npm install @redocly/cli@^1.12.0
npm ls jest-environment-jsdom

Screenshots

Additional context
Jest Instructions for DOM manipulation testing: https://jestjs.io/docs/next/tutorial-jquery

npm install --save-dev jest-environment-jsdom
@piotr-cz piotr-cz changed the title Installing v1.12.0 results in installing jest-environment-jsdom The v2.1.4 defines jest-environment-jsdom as prod dependency May 6, 2024
@AlexVarchuk AlexVarchuk linked a pull request May 23, 2024 that will close this issue
3 tasks
@AlexVarchuk
Copy link
Collaborator

@piotr-cz thank you for notifying us. PR opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants