Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large key-median value causes error even though it is between key-minimum and key-maximum #211

Open
clkbug opened this issue Apr 14, 2023 · 0 comments
Open

Large key-median value causes error even though it is between key-minimum and key-maximum #211

clkbug opened this issue Apr 14, 2023 · 0 comments

Comments

@clkbug
Copy link
Contributor

clkbug commented Apr 14, 2023

When a value exceeding 32 bits is set to key-median, the value will not be read correctly.

For example,

$ ./memtier_benchmark --key-pattern=G:G --key-minimum=10000000000 --key-maximum=30000000000 --key-median=20000000000
error: key-median must be between key-minimum and key-maximum.

(10000000000 is 34-bit value)

key-minimum and key-maximum are read correctly, but key-median is not.
clkbug added a commit to clkbug/memtier_benchmark that referenced this issue Apr 14, 2023
@clkbug
Fix issue RedisLabs#211. Allow key_stddev and key_median options to b…
2bf9737 
…e set values

exceeding unsigned int.
clkbug added a commit to clkbug/memtier_benchmark that referenced this issue Apr 17, 2023
@clkbug
Fix issue RedisLabs#211. Read key_stddev and key_median arguments as …
c5f2ddc 
…double
YaacovHazan pushed a commit that referenced this issue Apr 20, 2023
@clkbug
Fix issue #211. Allow key_stddev and key_median options to be set val…
d6083ed 
…ues (#212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clkbug