Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package contains non-optimized (Debug) assembly #84

Open
abogarsukov opened this issue Sep 12, 2018 · 2 comments · May be fixed by #95
Open

NuGet package contains non-optimized (Debug) assembly #84

abogarsukov opened this issue Sep 12, 2018 · 2 comments · May be fixed by #95

Comments

@abogarsukov
Copy link

For some reason NuGet package for the project contains non-optimized (Debug) assembly RSG.Promise.dll Is this intended? If not, please upload a new version with the release assembly.

@abogarsukov abogarsukov changed the title NuGet package is not optimized NuGet package contains non-optimized (Debug) assembly Sep 12, 2018
@Arvtesh
Copy link

Arvtesh commented Dec 25, 2018

Any updates on this one? It seems logical to have release assemblies in NuGet package.

@RoryDungan
Copy link
Contributor

Yeah this should probably be changed to the release one. There wasn't any particular reason I set it up that way apart from that it was the default config and I do sometimes find it useful being able to just copy the PDB files into a project and debug C-Sharp-Promise from there. Obviously that's a bit of a niche use-case because it only applies to people working on C-Sharp-Promise and for most people having a smaller DLL is better.

I don't work at RSG any more but if someone wanted to make a PR that changes the Nuget config to use release assemblies I don't see any reason why we couldn't merge it and push a new minor version out to Nuget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants