Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline functions instead of normal fun #202

Open
lkishor opened this issue Oct 31, 2018 · 1 comment
Open

inline functions instead of normal fun #202

lkishor opened this issue Oct 31, 2018 · 1 comment

Comments

@lkishor
Copy link

lkishor commented Oct 31, 2018

Thanks, for this awesome library on the top what Rx is 👍

fun Disposable.addTo(compositeDisposable: CompositeDisposable): Disposable = apply { compositeDisposable.add(this) }

Can this fun be inlined, and probably other functions with such small operations.
This would remove any overhead of this function call.

@vpriscan
Copy link
Collaborator

@thomasnield should we make all functions inline? This will especially be beneficial to android users as it will not increase methods count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants