Adding play 3.0 support. Fixes #564 #565
Conversation
project/Common.scala
Outdated
| @@ -20,8 +20,14 @@ object Common extends AutoPlugin { | |||
| driverVersion := { | |||
| val ver = (ThisBuild / version).value | |||
| val suffix = { | |||
| if (useShaded.value) "" // default ~> no suffix | |||
| else "noshaded" | |||
| val noshaded = "noshaded" | |||
There was a problem hiding this comment.
no need for such local "constant"
There was a problem hiding this comment.
I have removed the local constant
| } else { | ||
| ("org.reactivemongo" %% "reactivemongo-pekkostream" % buildVer) | ||
| .cross(CrossVersion.binary) | ||
| .exclude("org.apache.pekko", "*") // provided by Play |
There was a problem hiding this comment.
Can you specify your comment ?
build.sbt
Outdated
| } | ||
|
|
||
| baseDeps | ||
| } | ||
|
|
||
| lazy val reactivemongo = Project("Play2-ReactiveMongo", file(".")).settings( | ||
| lazy val reactivemongo = Project("Play-ReactiveMongo", file(".")).settings( |
There was a problem hiding this comment.
If it update the artifactId, it cannot be done as-is to keep compat
There was a problem hiding this comment.
I have reverted the naming of the project, However i don't know how you see the publishing of the play3 version. Should it be another subproject ? another git project ? maybe a dynamic naming of the artifact for publishing?
|
|
||
| import akka.stream.Materializer | ||
|
|
||
| object MongoController { |
There was a problem hiding this comment.
There was no need for that, how is it related with support for Play 3?
There was a problem hiding this comment.
The MongoController Trait references akka dependencies in the signature of functions and needed to be changed to pekko.
I though that the best way of changing from akka to pekko was to split the trait into a version specific file, resulting in the duplication of the file for every version under play 3.0.
* Removing local constant * Keep scala 2.12 as lower default * Formatting * Revert project name to Play2-ReactiveMongo * Add test to the pipeline
* Reverting the scala version from 3.3.3 to 3.2.2
|
Hi @cchantep, do you have any updates on this? Should I close the requested change once I believe it's completed and there are no further additions? |
Pull Request Checklist
Fixes
Fixes #564
Purpose
This PR adds support for Play 3.0.
What does this PR do?
Background Context
Why did you take this approach?
The only files referencing akka was MongoController, so it was modified per version. The build.sbt was edited to pull the correct dependencies, inspired by the way it was done in reactivemongo-play-json build.sbt.
References
#564